-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(medusa): Delete ProductOption on Product without Variants #1846
Conversation
🦋 Changeset detectedLatest commit: 9621a05 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small fixes here :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - one thing that we should consider, though, is whether it ever makes sense to have a product with no variants; i.e. this delete is already in an invalid_state.
What
Solves admin issue 166
Deleting a product option on a product without variants currently throws, because we are cleaning up variant options as well.
How
Only do variant clean up, if product has variants