Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(medusa): spread config to have custom props in config #1896

Closed
wants to merge 1 commit into from

Conversation

Inoir
Copy link

@Inoir Inoir commented Jul 23, 2022

As i mentioned here: #1837 custom props getting stripped of the config.
Results in problems in seeding with custom logic and custom props in config, cause there is no way to get this custom props into the service loader i.e.

This allows custom props in the config and still preserves the reserved config from medusa.

Question here is should the custom props inside an object called "customConfig" like @srindom suggested in the issue?
currently i dont see the point in changing the config from the real one loaded.

@Inoir Inoir requested a review from a team as a code owner July 23, 2022 18:37
@changeset-bot
Copy link

changeset-bot bot commented Jul 23, 2022

⚠️ No Changeset found

Latest commit: 4c93365

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant