fix: allow addresses to be AddressPayload or string on DraftOrder creation

[kasperkristensen]

What

• Allows shipping_addressand billing_addressbe either an AddressPayload or string as part of the create draft order endpoint props.

How

• Implements the same patterns as used for the similar Cart endpoints.

Why
The endpoint was using an old pattern for switching between addresses being either ids or payloads, which resulted in billing_address not being added during the creation process if it was not passed as an id.

Also

• Fixes the wrong payload types being used in js/react clients.

Closes CORE-720

[changeset-bot]

⚠️ No Changeset found

Latest commit: 87338b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[olivermrbl]

Nice catch!

I believe we should also allow you to pass address ids as payload when updating a draft order since we call CartService.update i.e. the payload to update-draft-order.ts should be:

@IsOptional()
  @IsType([AddressPayload, String])
  billing_address?: AddressPayload | string

  @IsOptional()
  @IsType([AddressPayload, String])
  shipping_address?: AddressPayload | string

What do you think?

[olivermrbl]

Can I get you to merge in latest from develop and resolve conflicts?

[srindom]

LGTM! Pending @olivermrbl for final approval 👍

[olivermrbl]

LGTM!