-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove deprecated dependency @hapi/joi
#2069
Conversation
🦋 Changeset detectedLatest commit: f7cc098 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…sa into chore/remove-deps-hapi-joi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I like the util approach keeping with using the same validator that is used in the api layer 😄
Question: Is there a specific reason to remove the lock files entirely from medusa-plugin-economic
and medusa-plugin-slack-notification
?
The dependencies should be taken care of by yarn workspaces similar to other packages 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What
@hapi/joi
joi
from several packagesmedusa-core-utils
in Medusa core to remove dependency onjoi
entirely