Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove deprecated dependency @hapi/joi #2069

Merged
merged 14 commits into from
Sep 5, 2022

Conversation

olivermrbl
Copy link
Contributor

@olivermrbl olivermrbl commented Aug 21, 2022

What

  • Removes deprecated dependency @hapi/joi
  • Removes unused dependency joi from several packages
  • Removes use of our validator from medusa-core-utils in Medusa core to remove dependency on joi entirely
    • Replace email validation with new util

@olivermrbl olivermrbl requested a review from a team as a code owner August 21, 2022 14:01
@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2022

🦋 Changeset detected

Latest commit: f7cc098

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
create-medusa-app Patch
@medusajs/medusa-cli Patch
medusa-plugin-economic Patch
medusa-plugin-slack-notification Patch
@medusajs/medusa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@olivermrbl olivermrbl requested review from srindom, pKorsholm and a team and removed request for pKorsholm September 2, 2022 08:16
Copy link
Contributor

@pKorsholm pKorsholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like the util approach keeping with using the same validator that is used in the api layer 😄

Question: Is there a specific reason to remove the lock files entirely from medusa-plugin-economic and medusa-plugin-slack-notification?

@olivermrbl
Copy link
Contributor Author

Is there a specific reason to remove the lock files entirely from medusa-plugin-economic and medusa-plugin-slack-notification?

The dependencies should be taken care of by yarn workspaces similar to other packages 👍

Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olivermrbl olivermrbl merged commit ad717b9 into develop Sep 5, 2022
@olivermrbl olivermrbl deleted the chore/remove-deps-hapi-joi branch September 5, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants