Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: removed prerequisite section and added required/optional tool section #2192

Merged
merged 6 commits into from
Sep 13, 2022
Merged

docs: removed prerequisite section and added required/optional tool section #2192

merged 6 commits into from
Sep 13, 2022

Conversation

RAY-EZ
Copy link
Contributor

@RAY-EZ RAY-EZ commented Sep 12, 2022

Removed "Prerequisite Background Knowledge" section
Created "Required Tools" and "Optional Tools" sections
Moved "Node.js", "Git", and "Medusa CLI" to Required Section
"PostgreSQL" and "Redis" to "Optional Section"

closes #2145

@RAY-EZ
docs: rearranged and removed installation section
f2a1a04 
> Removed "Prerequisite Background Knowledge" section
> Created "Required Tools" and "Optional Tools" sections
> Moved "Node.js", "Git", and "Medusa CLI" to Required Section 
> "PostgreSQL" and "Redis" to "Optional Section"
@RAY-EZ RAY-EZ requested a review from a team as a code owner September 12, 2022 16:53
@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2022 •
edited

⚠️ No Changeset found

Latest commit: 84db0f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

shahednasser
shahednasser requested changes Sep 13, 2022
View reviewed changes
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work @RAY-EZ I have made some requests for changes.

docs/content/tutorial/0-set-up-your-development-environment.mdx Outdated Show resolved Hide resolved
docs/content/tutorial/0-set-up-your-development-environment.mdx Show resolved Hide resolved
docs/content/tutorial/0-set-up-your-development-environment.mdx Outdated Show resolved Hide resolved
@shahednasser shahednasser merged commit a12d737 into medusajs:master Sep 13, 2022
@shahednasser
Copy link
Member

Thank you for your contribution! @RAY-EZ

@RAY-EZ RAY-EZ deleted the docs/updated-development-environment branch January 7, 2023 04:36
@RAY-EZ RAY-EZ restored the docs/updated-development-environment branch January 7, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahednasser shahednasser shahednasser approved these changes

Assignees
No one assigned
Labels
type: docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: remove the "Prerequisite Background Knowledge" in "Set up your development environment"
2 participants
@RAY-EZ @shahednasser