Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(medusa): Cleanup Tax lines in case of a failed cart completion #2212

Merged
merged 6 commits into from
Sep 15, 2022

Conversation

pKorsholm
Copy link
Contributor

What

  • remove tax lines in case an error is raised after they have been created

How

  • fetch cart being completed along with items.tax_lines and shipping_methods.tax_lines
    • flapmap items and shipping_options to only the tax lines and remove them

Why

  • hanging tax lines prevented any further action on the order

Fixes CORE-431

@pKorsholm pKorsholm requested a review from a team as a code owner September 15, 2022 09:06
@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2022

⚠️ No Changeset found

Latest commit: d0bb05d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@srindom
Copy link
Collaborator

srindom commented Sep 15, 2022

Could we add a quick integration test that does:

  • Complete cart
  • Fail: e.g., because payment is not authorized
  • Verify that tax lines are not present

@pKorsholm
Copy link
Contributor Author

@srindom added tests for when the completion strategy throws and error and for when the payment status is pending (in both cases the hanging lines would cause this error)

Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work 🎉

Good to merge once tests are fixed

@olivermrbl olivermrbl changed the title Fix(Medusa): Cleanup Tax lines in case of a failed cart completion fix(medusa): Cleanup Tax lines in case of a failed cart completion Sep 15, 2022
@olivermrbl olivermrbl merged commit 6f4b221 into develop Sep 15, 2022
@olivermrbl olivermrbl deleted the fix/remove-hanging-tax-lines branch September 15, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants