-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(medusa): Cleanup Tax lines in case of a failed cart completion #2212
Conversation
|
Could we add a quick integration test that does:
|
@srindom added tests for when the completion strategy throws and error and for when the payment status is pending (in both cases the hanging lines would cause this error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work 🎉
Good to merge once tests are fixed
What
How
items.tax_lines
andshipping_methods.tax_lines
items
andshipping_options
to only the tax lines and remove themWhy
Fixes CORE-431