Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(medusa): Expose list-currencies endpoint #2216

Merged
merged 1 commit into from
Sep 15, 2022
Merged

fix(medusa): Expose list-currencies endpoint #2216

merged 1 commit into from
Sep 15, 2022

Conversation

olivermrbl
Copy link
Contributor

What
Expose list-currencies endpoint by removing the feature flag guard on router

Tests
Separated test suite into FF and non-FF

@olivermrbl olivermrbl requested review from kasperkristensen and a team September 15, 2022 12:43
@olivermrbl olivermrbl requested a review from a team as a code owner September 15, 2022 12:43
@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2022

⚠️ No Changeset found

Latest commit: 63c8614

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

srindom
srindom approved these changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kasperkristensen
kasperkristensen approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@kasperkristensen kasperkristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olivermrbl olivermrbl merged commit 5d75e16 into develop Sep 15, 2022
@olivermrbl olivermrbl deleted the fix/expose-list-currencies branch September 15, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srindom srindom srindom approved these changes

@kasperkristensen kasperkristensen kasperkristensen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@olivermrbl @srindom @kasperkristensen