Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(medusa): Allow to filter customer groups by discount condition id #2346

Merged
merged 5 commits into from Oct 11, 2022
Merged

feat(medusa): Allow to filter customer groups by discount condition id #2346

merged 5 commits into from Oct 11, 2022

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Oct 4, 2022

What

  • Allow to filter customer groups by discount condition id
  • Extract findWithRelationsAndCount function to utilities in order to be reusable to compose such method as it is used in multiple places and duplicated

Tests

  • Add integration tests to check that customer groups are returned as expected depending on the discount condition id

FIXES CORE-641

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2022 •
edited

⚠️ No Changeset found

Latest commit: aeb6aaa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@adrien2p adrien2p marked this pull request as ready for review October 4, 2022 17:07
@adrien2p adrien2p requested a review from a team as a code owner October 4, 2022 17:07
pKorsholm
pKorsholm approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@pKorsholm pKorsholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

packages/medusa/src/services/customer-group.ts Outdated Show resolved Hide resolved
packages/medusa/src/services/customer-group.ts Show resolved Hide resolved
@adrien2p adrien2p force-pushed the feat/discount-condition-filters-customer-group branch from b5c4d83 to f992053 Compare October 5, 2022 10:24
srindom
srindom approved these changes Oct 9, 2022
View reviewed changes
Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olivermrbl olivermrbl merged commit 94c242f into develop Oct 11, 2022
@olivermrbl olivermrbl deleted the feat/discount-condition-filters-customer-group branch October 11, 2022 06:39
adrien2p added a commit that referenced this pull request Oct 11, 2022
@adrien2p
feat(medusa): Allow to filter customer groups by discount condition id (
4044974 
#2346)
ymaheshwari1 pushed a commit to ymaheshwari1/medusa that referenced this pull request Oct 26, 2022
@adrien2p @ymaheshwari1
feat(medusa): Allow to filter customer groups by discount condition id (
d72fdfc 
medusajs#2346)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srindom srindom srindom approved these changes

@pKorsholm pKorsholm pKorsholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adrien2p @srindom @pKorsholm @olivermrbl