Feat(medusa): Replace redis with ioredis + redis_options config module

[alacroix]

What

Use only one Redis client (ioredis) in medusa package instead of having ioredis + redis simultaneously.
Add also a redis_options field in the project config module to easily configure advanced options for Redis.

Why

When deploying Medusa in production with Redis, I encountered the problem that Redis clients doesn't work well by default with IPv6 addresses.

redis/ioredis#1576
redis/node-redis#1550

Medusa being on top of theses clients, we need to be able to configure it while staying backward compatible.

How

Replaced redis used in loaders/express.ts with ioredis. connect-redis used to store Express session is compatible with both clients. Maybe I'm missing an historic issue with the choice of double Redis clients.
Add second argument for all new Redis with redis_options (typed with the interface RedisOptions from ioredis now that we have only one client). If no defined, will do nothing so backward compatible.

Example:

// in medusa-config.js
module.exports = {
    ...
    redis_url: "redis://localhost:6379";
    redis_options: { family: 6 };
    ...
}
...
const redisClient = new Redis(
      configModule.projectConfig.redis_url,
      configModule.projectConfig.redis_options // if undefined, arg is ignored by ioredis
)

Testing

Don't know exactly how to test it in a proper way. I used patch-package on my project to have the changes working. Any suggestions welcomed :)

[changeset-bot]

⚠️ No Changeset found

Latest commit: 9295e65

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[sslotsky]

Big hopes for this as I believe it would solve my issue of being unable to connect to Redis in a Fly.io app! 🙏🏼

[durdenx]

@sslotsky have you found a solution?

[sslotsky]

@sslotsky have you found a solution?

@durdenx sort of 😂 I actually wound up going with Vendure instead

[durdenx]

I've found a solution for passing redis options with query strings : redis://user:pass@fly-project-redis.upstash.io/?family=IPv6

[sslotsky]

Nice! I was only just starting my project at the time so I didn't have much at all invested in Medusa. At this point I'm pretty thoroughly invested in Vendure but it's good to know that this is an option in case I want to try Medusa for something else.