fix(medusa): fix missing throw in the store cart create-payment-sessions #2568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b262ffd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Could this happen in other endpoints that use the work stages of the IdempotencyKeyService? If so, I think we should include them in the PR |
|
@olivermrbl no there is not, I ve already check while doing that PR. The only thing to do with some of them would be a clean up as the try catch is not necessary but I did not want to expand the scope of that PR to also includes those clean up as it was not the purpose of it |
|
Got it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The create payment sessions when getting an error was doing nothing with it. As pair the actual handling of those cases, I ve change the end point to re throw the error. The error will be then bubbled up to the error-handler which will manage to handle that error correctly
https://sentry.io/organizations/medusa-nc/issues/3729401711/?project=4504043043618816&query=transaction%3A%22POST+%2F%3Aid%2Fpayment-sessions%22&referrer=issue-stream