Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat Add user role to possible medusa user cli command #2656

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

a-finocchiaro
Copy link
Contributor

@a-finocchiaro a-finocchiaro commented Nov 22, 2022

This is related to issue #2617.

This feature will add the ability to include a role when creating a user via CLI with the -r flag. For example, the command below would create an admin user:

medusa user -e "user@email.com" -p "pa$$word" -r "admin"

@a-finocchiaro a-finocchiaro requested a review from a team as a code owner November 22, 2022 22:24
@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2022

⚠️ No Changeset found

Latest commit: bbbdf6f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@LWJerri
Copy link

LWJerri commented Nov 23, 2022

Hi. This PR can close #2617 issue.

@olivermrbl
Copy link
Contributor

Great contribution - thanks!

Have you tested it yourself?

@a-finocchiaro
Copy link
Contributor Author

@olivermrbl No problem, glad I could help and it seemed like a good one to use as my first issue to tackle!

I have tested it, it works great and created a user as an "admin".

@a-finocchiaro a-finocchiaro requested a review from a team as a code owner November 28, 2022 18:07
@a-finocchiaro a-finocchiaro force-pushed the feat/add_user_role_to_create_user_cmd branch from 42d1a62 to 888e62a Compare November 28, 2022 19:01
@a-finocchiaro a-finocchiaro force-pushed the feat/add_user_role_to_create_user_cmd branch from 888e62a to bbbdf6f Compare November 28, 2022 19:10
@a-finocchiaro
Copy link
Contributor Author

@olivermrbl I've been working on trying to get the tests to pass and all of them do except for the tests from medusa-payment-paypal for some reason. But even on the develop and master branches these tests are failing for me so it seems like maybe I'm just missing some required setup for those tests? I'm pretty stumped as to why those aren't passing at all, so I figured I'd post here and see what you think.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants