fix(medusa-plugin-sendgrid): Inject GiftCardService to eliminate undefined error
#2941
Conversation
🦋 Changeset detectedLatest commit: 7cfff7d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Can someone look at this PR and let me know if any changes is required? Thanks |
olivermrbl
changed the title
GiftCardService to eliminate undefined error
|
Also, please add a changeset bumping the Sendgrid plugin with the following message: |
Use utility to cover all currency cases. Co-authored-by: Oliver Windall Juhl <59018053+olivermrbl@users.noreply.github.com>
|
Perfect - will do and send the commit shortly. |
|
Thank you for catching this. Glad someone is working on it cant wait for it to be merged. |
Done |
|
@olivermrbl - Let me know if I need to do anything else? |
|
@RegisHubelia Your branch is out-of-date with the base. Can I get you to update? |
Just did! |
|
what is eta on this being merged? |
|
@RegisHubelia Can I get you to update your branch with latest from |
Done! |
This PR fixes an issue where gift card created from the admin portal wouldn't send using sendgrid.
Also - there is no order attached to the gift card when it's created trough the admin portal - so I revoved the return statement if there is no order and adjusted the data sent to the template based on what was there - I updated the documentation to reflect the "display_value".