Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(medusa-js): added resources for product categories #3157

Merged
merged 5 commits into from Feb 1, 2023

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Feb 1, 2023

What:

JS client resources for product categories

Why:

To manage product categories and managing product-category relationship

How:

  • adds a JS client resource for product categories.

RESOLVES CORE-1066
RESOLVES CORE-969
RESOLVES CORE-1061

@changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2023

🦋 Changeset detected

Latest commit: fff4e84

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/medusa-js Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@riqwan riqwan changed the title feat(medusa): added resources for product categories feat(medusa-js): added resources for product categories Feb 1, 2023
@riqwan riqwan marked this pull request as ready for review February 1, 2023 16:31
@riqwan riqwan requested a review from a team as a code owner February 1, 2023 16:31
@riqwan
Copy link
Contributor Author

riqwan commented Feb 1, 2023

@patrick-medusajs this also fixes all the OAS issues mentioned in CORE-1061

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@patrick-medusajs patrick-medusajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not reviewed the x-codeSamples but every else LGTM! Thx

@kodiakhq kodiakhq bot merged commit be0d364 into develop Feb 1, 2023
@kodiakhq kodiakhq bot deleted the feat/categories-js-client branch February 1, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants