feat(oas): Improve OAS by adding missing type object to schemas

[asprouse]

This PR improves the OAS by adding type: object to schemas that have properties and no type. While this attribute is not required for a valid spec, omitting it opens the possibilities of non-object input. See https://stackoverflow.com/a/47390723 for a detailed description of this behavior. When generating code or schemas from an OAS with tools like takeshape.io having type attributes is important to get the correct behavior.

[changeset-bot]

⚠️ No Changeset found

Latest commit: bef761f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[srindom]

@patrick-medusajs did we already do this with your OAS work or would it make sense to include?

[patrick-medusajs]

@srindom We did similar work but we didn't fix objects in arrays. We actually have a Linear for it - CORE-1024.
This would be a great addition to include. I can review the OAS changes in the JSDoc comments.

@shahednasser How would you like to proceed for merging such changes. Should it target develop? Would you prefer to exclude changes in docs and only merge changes in api/routes?

[shahednasser]

I don't think this change is necessary for master, so it's fine to do it under develop. I also prefer excluding files under docs from the PR as these are automatically generated when changes are merged into master.

[patrick-medusajs]

@asprouse Would would mind rebasing your branch to point to medusajs:develop and remove docs from the PR?

[asprouse]

@asprouse Would would mind rebasing your branch to point to medusajs:develop and remove docs from the PR?

@patrick-medusajs I rebased the PR as re-targeted it to develop. The docs changes were dropped in the rebase.

[patrick-medusajs]

LGTM

[olivermrbl]

LGTM! @asprouse before we merge, can I get you to merge in latest from develop and push?

[patrick-medusajs]

🎉 @asprouse, thank you for your contribution. Cheers!