Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(medusa): Allow method.data to be passed when creating/updating ShippingMethods in ClaimService #3205

Merged
merged 5 commits into from Feb 8, 2023

Conversation

kasperkristensen
Copy link
Contributor

@kasperkristensen kasperkristensen commented Feb 8, 2023

What

  • Allows passing data on shipping methods during claim creation and updates. Defaults to an empty object.

Testing

  • Updates a test so it also passes along shipping method data.

@kasperkristensen kasperkristensen requested a review from a team as a code owner February 8, 2023 09:05
@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2023

🦋 Changeset detected

Latest commit: 4d6faea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@medusajs/medusa Patch
@medusajs/inventory Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w. comments :)

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, super nice!

@olivermrbl olivermrbl changed the title fix(medusa): Removes non-existing param method.data and instead pass an empty object in ClaimService fix(medusa): Allow method.data in ClaimService Feb 8, 2023
@olivermrbl olivermrbl changed the title fix(medusa): Allow method.data in ClaimService fix(medusa): Allow method.data to be passed when creating/updating ShippingMethods in ClaimService Feb 8, 2023
@kodiakhq kodiakhq bot merged commit b9bda3b into develop Feb 8, 2023
@kodiakhq kodiakhq bot deleted the fix/shipping-method-data branch February 8, 2023 12:37
adrien2p pushed a commit that referenced this pull request Feb 13, 2023
…ShippingMethods in ClaimService (#3205)

**What**
- Allows passing data on shipping methods during claim creation and updates. Defaults to an empty object.

**Testing** 
- Updates a test so it also passes along shipping method data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants