Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Typeorm to Medusa fork #3981

Merged
merged 6 commits into from
May 2, 2023
Merged

Conversation

olivermrbl
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented May 2, 2023

🦋 Changeset detected

Latest commit: f4995b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@medusajs/inventory Patch
@medusajs/medusa Patch
@medusajs/stock-location Patch
@medusajs/types Patch
@medusajs/utils Patch
@medusajs/admin-ui Patch
@medusajs/admin Patch
@medusajs/medusa-js Patch
medusa-payment-paypal Patch
medusa-payment-stripe Patch
medusa-plugin-meilisearch Patch
medusa-plugin-restock-notification Patch
medusa-react Patch
@medusajs/medusa-oas-cli Patch
@medusajs/cache-inmemory Patch
@medusajs/cache-redis Patch
@medusajs/event-bus-local Patch
@medusajs/event-bus-redis Patch
medusa-plugin-algolia Patch
@medusajs/modules-sdk Patch
@medusajs/medusa-cli Patch
@medusajs/oas-github-ci Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) Visit Preview May 2, 2023 0:17am

@@ -56,7 +56,7 @@ jobs:

- name: Create Medusa project
run: |
medusa new cli-test
medusa new cli-test 'https://github.com/medusajs/medusa-starter-default/tree/ci-test'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment: Will be removed again, when our starter template has been updated

@olivermrbl olivermrbl marked this pull request as ready for review May 2, 2023 10:17
@olivermrbl olivermrbl requested a review from a team as a code owner May 2, 2023 10:17
@olivermrbl olivermrbl requested review from riqwan and adrien2p May 2, 2023 10:17
Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This looks much cleaner.

Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me LGTM, do we have to update the starter and also mentioned to the users that they have to install the peers from our package?

@olivermrbl
Copy link
Contributor Author

Looks good to me LGTM, do we have to update the starter and also mentioned to the users that they have to install the peers from our package?

Yep, we'll have to update the starter to use our Typeorm version too.

@olivermrbl olivermrbl merged commit d539c6f into develop May 2, 2023
@github-actions github-actions bot mentioned this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants