Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(plugin): paypal integration missing createOrder callback #6401

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

raiyansarker
Copy link
Contributor

This PR adds missing information in paypal plugin docs which is crucial to its use. Previously, docs didn't mention about createOrder callback that is required by PayPal sdk to connect with backend for details like currency and amount to be charged. Medusa backend responds with required id for the PayPal sdk to use. Related to medusajs/nextjs-starter-medusa#260 (comment)

@raiyansarker raiyansarker requested a review from a team as a code owner February 14, 2024 17:44
Copy link

changeset-bot bot commented Feb 14, 2024

⚠️ No Changeset found

Latest commit: ae13ef0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 14, 2024

@raiyansarker is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@raiyansarker raiyansarker changed the title fix: paypal integration missing createOrder callback docs(plugin): paypal integration missing createOrder callback Feb 16, 2024
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for leaving this PR hanging, thank you for your contribution!

@kodiakhq kodiakhq bot merged commit 9d46671 into medusajs:develop Apr 2, 2024
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants