Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(medusa, user, core-flows): User creation with invites #6413

Merged
merged 16 commits into from
Feb 19, 2024
Merged

Feat(medusa, user, core-flows): User creation with invites #6413

merged 16 commits into from
Feb 19, 2024

Conversation

pKorsholm
Copy link
Contributor

@pKorsholm pKorsholm commented Feb 15, 2024 •
edited

What

  • add accept invite endpoint

Invite accept flow

  • authenticate using the auth endpoint to create and auth-user
  • invoke accept endpoint with token and info to create user

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2024 •
edited

⚠️ No Changeset found

Latest commit: a0b2ad9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 15, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 5:04am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 19, 2024 5:04am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2024 5:04am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2024 5:04am

@pKorsholm pKorsholm marked this pull request as ready for review February 16, 2024 09:41
@pKorsholm pKorsholm requested review from a team as code owners February 16, 2024 09:41
srindom
srindom approved these changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w. comments!

packages/medusa/src/api-v2/admin/invites/middlewares.ts Outdated Show resolved Hide resolved
packages/user/src/services/invite.ts Outdated Show resolved Hide resolved
packages/user/src/services/invite.ts Show resolved Hide resolved
packages/user/src/services/invite.ts Outdated Show resolved Hide resolved
packages/user/src/services/invite.ts Outdated Show resolved Hide resolved
packages/user/src/services/invite.ts Outdated Show resolved Hide resolved
packages/user/src/services/user-module.ts Outdated
@@ -60,6 +62,16 @@ export default class UserModuleService<
this.inviteService_ = inviteService
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this.inviteService_ = inviteService
this.inviteService_ = inviteService.withModuleOptions(moduleDeclaration)

@srindom
Copy link
Collaborator

srindom commented Feb 16, 2024

Feel free to address comments or not and add automerge.

@kodiakhq kodiakhq bot merged commit f6d3816 into develop Feb 19, 2024
17 checks passed
@kodiakhq kodiakhq bot deleted the feat/user-creation-api-v2 branch February 19, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srindom srindom srindom approved these changes

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pKorsholm @srindom