Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): Mikro orm prop filtering should check existence #6842

Merged
merged 10 commits into from
Mar 27, 2024

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Mar 27, 2024

What

  • Should return non decorated but visible properties.
  • Should only prevent circular on non scalar fields

Copy link

changeset-bot bot commented Mar 27, 2024

🦋 Changeset detected

Latest commit: 64e3e65

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@medusajs/utils Patch
@medusajs/promotion Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview Mar 27, 2024 2:19pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 2:19pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-ui ⬜️ Ignored (Inspect) Visit Preview Mar 27, 2024 2:19pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Mar 27, 2024 2:19pm

@adrien2p
Copy link
Member Author

@olivermrbl for some reason, the previous pr was containing a bug, though, all pipeline were green.

cc @riqwan, I was surprised that they ran in a few sec when you look in details, something link to the cache maybe?

@adrien2p
Copy link
Member Author

I ll try to update the test to reflect that

@adrien2p
Copy link
Member Author

@riqwan , If i run the test locally, they are failing, though the pipeline is green

@kodiakhq kodiakhq bot merged commit 5d9aea0 into develop Mar 27, 2024
24 checks passed
@kodiakhq kodiakhq bot deleted the fix/mikro-orm-serialization branch March 27, 2024 14:31
@riqwan
Copy link
Contributor

riqwan commented Mar 27, 2024

@adrien2p yeah, the cache doesn't seem to be busting. Let me take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants