Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typedoc errors and warnings #7006

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

shahednasser
Copy link
Member

Fix typedoc errors and warning shown during reference generation

Copy link

changeset-bot bot commented Apr 8, 2024

🦋 Changeset detected

Latest commit: 5c2d1bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 10:37am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Apr 8, 2024 10:37am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 10:37am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 10:37am

Comment on lines -286 to -305
/**
* The customer group to be created.
*/
export interface CreateCustomerGroupDTO {
/**
* The name of the customer group.
*/
name: string

/**
* Holds custom data in key-value pairs.
*/
metadata?: Record<string, unknown> | null

/**
* Who the customer group.
*/
created_by?: string
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clarification: this interface is defined twice in the same file. So, I removed one of the definitions

@shahednasser shahednasser merged commit 78f603e into develop Apr 9, 2024
24 checks passed
@shahednasser shahednasser deleted the fix/typedoc-errors branch April 9, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants