-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix for subscriber logic in digital products recipe #7184
docs: fix for subscriber logic in digital products recipe #7184
Conversation
|
@eskoniarek is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! Just a small comment below
for (const item of order.items) { | ||
const productMedias = await productMediaService | ||
.retrieveMediasByVariant(item.variant) | ||
const downloadUrl = await Promise.all( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change the variable name to downloadUrls
(it's more fitting)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks again
Update the subscriber code snippet in Digital Product recipe, to properly wait for the pre-signed URL for each item's media.
Closes #7170