-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard, order, medusa, types, js-sdk): Request return e2e flow #7848
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
|
# Conflicts: # packages/modules/order/src/migrations/Migration20240604100512.ts
@fPolic, this PR will not include return receival and the activity list changes, right? For the latter see image below: ![]() |
I started working on the receival flow in a separate branch. Regarding activity list, good reminder, I'll add it to this PR. |
Cool, sounds good! |
'partially_received', | ||
'canceled' | ||
); | ||
DO $$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: What triggered these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had migration failing because I already had that type in the DB but since Postgres doesn't support create type if not exist...
this is equivalent.
// TODO: this should be `fulfilled_quantity`? now there is check on the BD that we can't return more quantity than we shipped but some items don't require shipping | ||
shipped_quantity, | ||
return_received_quantity, | ||
return_dismissed_quantity, // TODO: check this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few TODOs here, just adding a comment to ensure we are aware of these
What
Note
custom_price
can be set but it cannot be inferred back when we refresh since the field is not saved explicitly in the databaseCLOSES CC-73
CLOSES CC-240