Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard, order, medusa, types, js-sdk): Request return e2e flow #7848

Merged
merged 92 commits into from
Jul 24, 2024

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Jun 26, 2024

What

  • add create return flow
  • fix routing
  • fix migrations issue with existing enum types

Note

  • custom_price can be set but it cannot be inferred back when we refresh since the field is not saved explicitly in the database


CLOSES CC-73
CLOSES CC-240

Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 4:18pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jul 24, 2024 4:18pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 4:18pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 4:18pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 4:18pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 4:18pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 4:18pm

Copy link

changeset-bot bot commented Jun 26, 2024

⚠️ No Changeset found

Latest commit: b0be548

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

# Conflicts:
#	packages/modules/order/src/migrations/Migration20240604100512.ts
@olivermrbl
Copy link
Contributor

olivermrbl commented Jul 24, 2024

@fPolic, this PR will not include return receival and the activity list changes, right? For the latter see image below:

CleanShot 2024-07-24 at 16 22 34@2x

@fPolic
Copy link
Contributor Author

fPolic commented Jul 24, 2024

@fPolic, this PR will not include return receival and the activity list changes, right? For the latter see image below:

I started working on the receival flow in a separate branch. Regarding activity list, good reminder, I'll add it to this PR.

@olivermrbl
Copy link
Contributor

Cool, sounds good!

'partially_received',
'canceled'
);
DO $$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: What triggered these changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had migration failing because I already had that type in the DB but since Postgres doesn't support create type if not exist... this is equivalent.

Comment on lines +5 to +8
// TODO: this should be `fulfilled_quantity`? now there is check on the BD that we can't return more quantity than we shipped but some items don't require shipping
shipped_quantity,
return_received_quantity,
return_dismissed_quantity, // TODO: check this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few TODOs here, just adding a comment to ensure we are aware of these

@olivermrbl olivermrbl merged commit f7d1cd2 into develop Jul 24, 2024
23 checks passed
@olivermrbl olivermrbl deleted the feat/rma-create-return branch July 24, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants