Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping of X and Y buttons is mirrored #2

Closed
NoXPhasma opened this issue Dec 21, 2019 · 7 comments
Closed

Mapping of X and Y buttons is mirrored #2

NoXPhasma opened this issue Dec 21, 2019 · 7 comments
Labels
bug Something isn't working

Comments

@NoXPhasma
Copy link
Contributor

The X and Y buttons are mirrored, X is recognized as Y and vis versa. I guess there is something mixed up in the code :)

@medusalix
Copy link
Owner

medusalix commented Dec 21, 2019

Buttons are mapped according to the Linux docs. So the DPAD is mapped using BTN_NORTH, BTN_EAST, BTN_SOUTH and BTN_WEST. Unfortunately, it looks like BNT_NORTH is equivalent to BTN_X on Linux. I'm not sure which button scheme works best for actual games.

@NoXPhasma
Copy link
Contributor Author

NoXPhasma commented Dec 21, 2019

The X and Y buttons definitely doesn't follow what the XBOX One S controller is mapped with xpad (wired), hid_microsoft (bluetooth) or xpadneo (bluetooth). No matter what game/tool I use, it's wrong in all of them.

@medusalix
Copy link
Owner

Should we just ignore the docs and map the buttons using BTN_A, BTN_B, BTN_X and BTN_Y?

@NoXPhasma
Copy link
Contributor Author

I think we should go the same route as xpadneo and xpad go. As this would make sure it's recognized the same way and we don't run into any issues.

I've also just found out that the DPAD won't be recognized in games as well. You've mapped it as buttons 11-14, but apparently with xpad it's mapped as axes 6 and 7.

@NoXPhasma
Copy link
Contributor Author

Your commit (502abcf) fixed the wrong Y and X mapping. Now only the DPAD is left and the controller works as intended :)

@medusalix
Copy link
Owner

The latest commit should've now fixed the DPAD.

@NoXPhasma
Copy link
Contributor Author

It does, the mapping is now as expected.

@medusalix medusalix added the bug Something isn't working label Dec 25, 2019
igiona pushed a commit to Scewo/xow that referenced this issue May 16, 2024
Pid file

Approved-by: Joram Liebeskind
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants