Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge to one package #5

Merged
merged 20 commits into from Aug 31, 2022
Merged

Merge to one package #5

merged 20 commits into from Aug 31, 2022

Conversation

skillLan
Copy link
Collaborator

No description provided.

@skillLan skillLan requested a review from medz August 29, 2022 19:54
@skillLan skillLan linked an issue Aug 29, 2022 that may be closed by this pull request
2 tasks
@skillLan skillLan self-assigned this Aug 29, 2022
@Ali1Ammar
Copy link
Collaborator

I see you are changing the downloader and merge it into the BinaryEngine class
but i also change it and add a BinaryEngineManger to mange the downloading, caching, versioning and copying the engine
all the conflicts is about change from BinaryEngineDownloader into BinaryEngineManger

so if you could take a look at this code prisma_cli/lib/src/engine_downloader/binary_engine_manger.dart and merge the missing part it into the BinaryEngine will just fine and you could ignore the conflicts

@medz medz merged commit d388a7d into main Aug 31, 2022
@medz medz deleted the merge-to-one-package branch August 31, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge all packages to one package
3 participants