Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated countries.json to support more use-cases and variations #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

draganovik
Copy link

+ Added new country names (ex. Swaziland now has Eswatini)
- Removed no-longer supported flag (Netherlands Antilles)
+ Added each country native name and alternative names
+ Added country cca3 code

+ Added new country names (ex. Swaziland now has Eswatini)
- Removed no-longer supported flags (ex. Netherlands Antilles)
+ Added each country native name and alternative names
+ Added country cca3 code
@draganovik
Copy link
Author

PS: While working on personal projects I've run into issues with this package, I love the idea and I would like to contribute to this project to make it even better.

@BrodaNoel
Copy link
Collaborator

@draganovik I'll be taking a look at the PRs and issues during the following day.
Could you please fix the indentation and only add the new countries/changes you want? I think it's a good idea to keep those arrays in 1 line.

@draganovik
Copy link
Author

Hi @BrodaNoel, thank you for looking into this.
Indentation has been fixed.

Could you please elaborate what you meant by:

[...] and only add the new countries/changes you want?

Are any additional changes needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants