Skip to content

Commit

Permalink
configure: compare which's result against "x", not "xno"
Browse files Browse the repository at this point in the history
This was apparently copy-pasted from the AC_PATH_PROG checks above.
`which` doesn't return a "no" result if it fails, unlike AC_PATH_PROG.

This typo would make the configure phase pass even if there were no
gapi tools installed.
  • Loading branch information
knocte committed Jan 30, 2015
1 parent 385fbd3 commit 68bebcd
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ AC_PATH_PROG(GAPI_PARSER, gapi2-parser, no)
if test "x$GAPI_PARSER" = "xno"; then
AC_MSG_CHECKING(for gapi2-parser.exe)
GAPI_PARSER=`$WHICH gapi2-parser.exe`
if test "x$GAPI_PARSER" = "xno" ; then
if test "x$GAPI_PARSER" = "x" ; then
AC_MSG_ERROR(['gapi2-parser'/'gapi2-parser.exe' not found.])
fi
AC_MSG_RESULT($GAPI_PARSER)
Expand All @@ -119,7 +119,7 @@ AC_PATH_PROG(GAPI_FIXUP, gapi2-fixup, no)
if test "x$GAPI_FIXUP" = "xno"; then
AC_MSG_CHECKING(for gapi2-fixup.exe)
GAPI_FIXUP=`$WHICH gapi2-fixup.exe`
if test "x$GAPI_FIXUP" = "xno" ; then
if test "x$GAPI_FIXUP" = "x" ; then
AC_MSG_ERROR(['gapi2-fixup'/'gapi2-fixup.exe' not found.])
fi
AC_MSG_RESULT($GAPI_FIXUP)
Expand All @@ -131,7 +131,7 @@ AC_PATH_PROG(GAPI_CODEGEN, gapi2-codegen, no)
if test "x$GAPI_CODEGEN" = "xno"; then
AC_MSG_CHECKING(for gapi2_codegen.exe)
GAPI_CODEGEN=`$WHICH gapi2_codegen.exe`
if test "x$GAPI_CODEGEN" = "xno" ; then
if test "x$GAPI_CODEGEN" = "x" ; then
AC_MSG_ERROR(['gapi2-codegen'/'gapi2_codegen.exe' not found.])
fi
AC_MSG_RESULT([$GAPI_CODEGEN])
Expand Down

0 comments on commit 68bebcd

Please sign in to comment.