Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all config types and fix generated link (#1) #2

Conversation

crutch12
Copy link
Contributor

Support for #1

And fix build link - removed appFullName, using EAS_BUILD_USERNAME and appInfo.slug

Before
https://expo.dev/accounts/@test/testApp/7d727cf3-9ac5-47a0-810c-e5bfd2ade10d

After
https://expo.dev/accounts/test/projects/testApp/builds/7d727cf3-9ac5-47a0-810c-e5bfd2ade10d

@crutch12 crutch12 changed the title Support all config types (#1) and fix generated link Support all config types and fix generated link (#1) Sep 10, 2022
@crutch12 crutch12 force-pushed the feature/support-all-config-types branch from 92ac7f2 to efe44a3 Compare September 10, 2022 02:10
@crutch12
Copy link
Contributor Author

Also added Platform info output

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thank you very much for contributing

@mariomurrent-softwaresolutions mariomurrent-softwaresolutions added the enhancement New feature or request label Sep 10, 2022
@mariomurrent-softwaresolutions mariomurrent-softwaresolutions merged commit 12d3046 into meecodebymariomurrent:master Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants