-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add socks_endpoint kwarg to TorClientEndpoint's constructor #182
Closed
Closed
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3cc23fc
Add socks_socket kwarg to TorClientEndpoint's constructor
david415 594e8ed
Change socks_socket to socks_endpoint
david415 7682481
Define kwargs once before the conditional
david415 72dc86f
Make tor client endpoint only use socks_endpoint
david415 e2251a2
backwards-compatibility
meejah 218c8b9
fix utest
meejah 0d65fae
Fix endpoint parser to use new API
meejah f224b98
fix another utest
meejah 7162418
remove dead code
meejah 31a46dd
test default ports properly
meejah ace31f5
fix docstring and add tls option
meejah 30515aa
Merge pull request #3 from meejah/181.unix_socks.0
david415 c6cfd17
Remove duplicate if statement
david415 76eb103
Merge remote-tracking branch 'origin/181.unix_socks.0' into 181.unix_…
david415 6e85838
Add pyopenssl dependency
david415 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,3 +5,4 @@ Twisted>=11.1.0 | |
| ipaddress>=1.0.16 | ||
| zope.interface>=3.6.1 | ||
| txsocksx>=1.13.0 | ||
| pyopenssl>=16.1.0 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this get added by Twisted? Or is that an optional thing? (I mean: I don't think txtorcon actually directly depends on pyopenssl, does it?)