Ticket284 when disconnected docs release notes #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
p.s. another improvement / PR in this vein would be to update "internal" use from |
|
I will look at this for sure. Still trying to get more comfortable.
…On Tue, Oct 30, 2018, 2:02 PM meejah, ***@***.***> wrote:
p.s. another improvement / PR in this vein would be to update "internal"
use from .on_disconnect -> .when_disconnected(). I see at least
examples/web_onion_service_filesystem.py uses it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#325 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/Ab4ax-gz7cZI9UQkeHT01j-oh7ifG2pAks5uqLBYgaJpZM4YCBfM>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put this to the correct base. Thank for your help @meejah !!