Fixed two tests, fixes for PyP #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, looks great! (p.s. feel free to add comments about such changes to the "unreleased" version in docs/releases.rst for future fixes/features etc) |
ghtdak
pushed a commit
to ghtdak/txtorcon
that referenced
this pull request
Oct 2, 2015
Fixed two tests, fixes for PyP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
here are two fixes for unflushed buffers leading to a race condition on slow IO, causing unittests to fail.
There was also a subtle bug in torstate.py due to a identity-comparison against a string: Comparisons against immutable objects (such as a string) based on identity ("foo is bar") usually get you more than you ask for. Due to the way PyPy handles the situation, a comparison fails - strings are equal but not identical - and hidden services are never considered having a unique name...
edit: there is a discussion about the above right now at http://mail.python.org/pipermail/pypy-dev/2013-May/011299.html
Fixing the above, the test-suite now passes on Linux 3.0.8+ armv7l using PyPy 2.0 alpha