-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update some packages #87
Conversation
bezumkin
commented
Aug 22, 2015
- It seems that lessphp is officially dead - it even can`t compile Bootstrap 3! So i suggest you to replace it to oyejorge/less.php. We already use it in MODX component MinifyX and it works great!
- Version 6.0.0 of sabberworm/php-css-parser fails on PHP 5.3.3, so i changed it to dev-master.
@bezumkin: If you are updating the less php library, you need to update the code that does the compiling. That is found here: https://github.com/meenie/munee/blob/master/src/Munee/Asset/Type/Css.php |
It seems that oyejorge/less.php replaces leafo/lessphp and provides similar class. I have no errors for now and nobody create issues about it in MinifyX. We use oyejorge/less.php with munee more than year |
Oops! I should have looked at it closer ><. Sorry about that :). As for pointing to So If you don't mind, can we please wait until he does that? If it's more than a couple of days, I'll ping him again. Thanks for your PR :). |
Yes, of course! Thanks! |
@bezumkin, PHP-CSS-Parser has been tagged with 7.0.0 :). Please update your PR and we'll get it merged/released. |
Also, please remove the |
Hi @bezumkin, try running |
@bezumkin: The issue is Packagist hasn't pulled in his latest tag. I've pinged him on it and hopefully it will be resolved soon :). https://packagist.org/packages/sabberworm/php-css-parser |
@bezumkin: See his update here: MyIntervals/PHP-CSS-Parser#95 (comment) |
@bezumkin: Looks like the |
Done! |
Cool, thanks! |