Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font type created #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Font type created #92

wants to merge 1 commit into from

Conversation

Crecket
Copy link

@Crecket Crecket commented Jan 24, 2016

This should fix the font-encoding issue for libraries like Font-Awesome. All it does is return the font-file and it stops Munee from returning the "Error: The following extension is not handled: woff2" error.
#91

@meenie
Copy link
Owner

meenie commented Jan 24, 2016

I feel like this is only an issue if you are using Munee without using a RewriteRule. So we shouldn't even be passing a font file through Munee. So the best way to go about this is to fix this part of the code:. If there were a good reason to run Fonts through Munee, this would be the 100% best fix.

What do you think?

@Crecket
Copy link
Author

Crecket commented Jan 25, 2016

I agree that it isn't the best way to go about this though, I'm not sure how we can fix it though. The code you referenced isn't reached because the Registry returns a File is not handled error

@meenie
Copy link
Owner

meenie commented Jan 25, 2016

The reason it's running the font through Munee is because:

  1. You are not using a RewriteRule, meaning you are using munee like: munee.php?files=my-css.css
  2. Munee knows that you aren't using a RewriteRule, so when it compiles the CSS, it rewrites all URLs to prefix them with munee.php?files=<path-to-file>.

If you were using a RewriteRule, this wouldn't be an issue, because Munee would not try to rewrite the URLs to run them through munee.php?files=<path-to-file>.

So to stop this, in the code I linked to above, it needs to not rewrite the URL if it's a font. I hope that makes sense :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants