Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CH341 with challenge codes #1658

Merged
merged 30 commits into from
Feb 12, 2023
Merged

New CH341 with challenge codes #1658

merged 30 commits into from
Feb 12, 2023

Conversation

tatarize
Copy link
Member

  • Challenge codes respond true with a 204 for about half a second after the challenge is issued. This means to read or process a device by the serial number we must perform this protocol step. If it remains 206 the challenge was failed, if it was successful then we mark the device based on the known serial number.
  • The issue with this is that the core CH341 does the decision of the connection/non-connection of the different elements. This PR is an attempt to simplify the CH341 interfacing to use a simple connection rather than a series of handlers.
  • Also we move the connection/non-connection into the lihuiyu controller.
  • The original code is left intact for Moshi which also uses CH341.

Due to the nature of this PR it can't be merged without being fully tested and vetted and probably can't be added until after the next full version release.

@tatarize tatarize marked this pull request as draft January 14, 2023 05:20
@tatarize
Copy link
Member Author

This might actually be close. It was actually appearing to check for serial numbers and rejecting devices based on the reply.

@tatarize tatarize marked this pull request as ready for review January 26, 2023 06:33
@tatarize tatarize modified the milestones: 0.8.2, 0.8.3 Jan 26, 2023
@tatarize tatarize added Type: Enhancement New feature or request Status: On Hold May also be assigned to someone because of their experience, but it's recognised they are unable to Priority: Medium This issue may be useful, and needs some attention. Work: Completed There is no more work left to do for this issue/PR Hardware: M2 Nano Lihuiyu Studios M2 Nano labels Jan 26, 2023
@tatarize
Copy link
Member Author

Should need full testing anyway.

@tatarize tatarize merged commit 0550b0f into main Feb 12, 2023
@tatarize tatarize deleted the ch341-new branch February 12, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hardware: M2 Nano Lihuiyu Studios M2 Nano Priority: Medium This issue may be useful, and needs some attention. Status: On Hold May also be assigned to someone because of their experience, but it's recognised they are unable to Type: Enhancement New feature or request Work: Completed There is no more work left to do for this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant