Missing font fix - speedup of large font-sizes #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of deficiencies around the treatment of text elements:
File:
Was:
a) Some font-properties like font-size and others were not properly recognised
after fixing this it became evident
b) that the treatment of establishing the text size was flawed as the size of the text box needed to be established every single time as paint_bounds was dirty by defintion
c) A large font-size that was reduced by a viewport would generate huge preview pictures (25000 x 6000 pixels) which made the manipulation of such elements nearly impossible