Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Adjust property label colors #147

Closed
tilmx opened this issue Dec 22, 2017 · 5 comments
Closed

Adjust property label colors #147

tilmx opened this issue Dec 22, 2017 · 5 comments

Comments

@tilmx
Copy link
Member

tilmx commented Dec 22, 2017

The property item labels on the right side have different colors.

The string property label is darker than an enum/select label. We should use the dark grey from the enum-label for all property items.

Developer note:
The styling for the property items is here (as styled components):
alva/src/lsg/patterns

bildschirmfoto 2017-12-22 um 15 08 27

@bing107
Copy link

bing107 commented Dec 22, 2017

Hi, I would like to take this issue if its still available. I'd really appreciate some guidance if possible as this would be my first issue. Cheers.

@lkuechler
Copy link
Member

@bing107
Hi. You can take it if you want.
The file that you need to change should be src/lsg/patterns/property-items/string-item/index.tsx. The label should have the same color variable like the other property-items.

If there are additional questions just ask :)

@bing107
Copy link

bing107 commented Dec 22, 2017

Cool, thank you! :)

@tilmx
Copy link
Member Author

tilmx commented Dec 22, 2017

Hey @bing107! Thank you very much for contributing!
As @lkuechler mentioned have a look at the three property-items and check, if every item (enum/string/boolean) has the grey36-color. If you have any questions, let us know!

@bing107
Copy link

bing107 commented Dec 22, 2017

Hi @tilmx, no problem :). And I'll ask if I get stuck. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants