Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICE Restarts documentation is incomplete #1238

Closed
anildigital opened this issue May 17, 2018 · 2 comments
Closed

ICE Restarts documentation is incomplete #1238

anildigital opened this issue May 17, 2018 · 2 comments

Comments

@anildigital
Copy link

I am finding Janus ICE Restart documentation as incomplete.

https://janus.conf.meetecho.com/docs/JS.html

It doesn't talk about update or restart configure request options. It also misses how to handle ICE Restart for videoroom subscribers.

It links to this PR #753 .. but PR might have old docs which are not up-to-date with the latest code.

An example for ICE Restart with plugins such as videoroom would be a great addition.

Thanks
@lminiero
Copy link
Member

It's not there because it's plugin specific. Look at the videoroom docs for those. Closing.

lminiero added a commit that referenced this issue May 21, 2018
@lminiero
Clarified in the docs that for renegotiations and ICE restart you hav…
df84e37 
…e to check plugin docs as well (see #1238)
@lminiero
Copy link
Member

Made it clearer in the generic docs as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anildigital @lminiero