Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unauthenticated no-payload ping endpoint for health checks #3336

Closed
husam212 opened this issue Feb 28, 2024 · 3 comments
Closed

Add unauthenticated no-payload ping endpoint for health checks #3336

husam212 opened this issue Feb 28, 2024 · 3 comments
Labels
enhancement multistream Related to Janus 1.x

Comments

@husam212
Copy link

husam212 commented Feb 28, 2024 •
edited
Loading

The current admin ping request is unauthenticated, but it requires a JSON payload, it's not possible to add a payload to health checks in most web servers (for example Caddy and Nginx) and DNS services (for example Route53 and Cloudflare). This makes it hard to implement auto-failover using reverse proxy or DNS service, it would be useful to have a dedicated URI /ping for health checks that doesn't require a payload.
@husam212 husam212 added the multistream Related to Janus 1.x label Feb 28, 2024
@lminiero
Copy link
Member

That's a good suggestion, thanks! I'll see if that can be added to the HTTP transport.

@lminiero
Copy link
Member

Implemented in the commit above for both Janus and Admin APIs.

lminiero added a commit that referenced this issue Feb 28, 2024
@lminiero
Expose Janus and Admin API ping request via GET too, when using HTTP (f…
35e3719 
…ixes #3336)
@husam212
Copy link
Author

Thanks! That was quick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement multistream Related to Janus 1.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@husam212 @lminiero