Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Crash / segfault on 1.2.2 #3354

Closed
tespio opened this issue Apr 8, 2024 · 5 comments · Fixed by #3355
Closed

[1.x] Crash / segfault on 1.2.2 #3354

tespio opened this issue Apr 8, 2024 · 5 comments · Fixed by #3355

Comments

@tespio
Copy link

tespio commented Apr 8, 2024

What version of Janus is this happening on?
Janus version: 1202 (1.2.2) Janus commit: #3346

Have you tested a more recent version of Janus too?
No. Since March 22 when i've compiled this commit with libasan it just crashed today.

Was this working before?
Well, intermittently, mostly yes, but since we started using 1.2.1 had several segfaults (as reported HERE on March 22)

Is there a gdb or libasan trace of the issue?
https://gist.github.com/tespio/1ffdc026c90bc2337b84492b656cf626

Additional context
It seems like I have more or less the same asan dump like the one mentioned on discourse HERE

@tespio tespio added the multistream Related to Janus 1.x label Apr 8, 2024
@tespio tespio changed the title [1.2.2] Crash / segfault on 1.2.2 [1.x] Crash / segfault on 1.2.2 Apr 8, 2024
@atoppi atoppi added the bug label Apr 8, 2024
@atoppi
Copy link
Member

atoppi commented Apr 8, 2024

@tespio @RSATom please test #3355

@tespio
Copy link
Author

tespio commented Apr 8, 2024

I've recompiled with the #3355 but it may take a while until I can come back with some observations, if any. (hopefully if it doesn't crash anymore so there won't be any observation to be made :) )

@tespio
Copy link
Author

tespio commented Apr 23, 2024

Okay, here we go again @atoppi. It took a while but it crashed again.

https://gist.github.com/tespio/4ac1473acb77cc7a0c8cda3ed9834a5d

@atoppi
Copy link
Member

atoppi commented Apr 24, 2024

@tespio this one looks different. A destroy room request has freed a room that was being accessed while handling a RTP packet of one of the participants.
Please open a new issue.

If the previous crash is not happening anymore we'll close this one and merge the proposed patch.

@tespio
Copy link
Author

tespio commented Apr 24, 2024

@tespio this one looks different. A destroy room request has freed a room that was being accessed while handling a RTP packet of one of the participants. Please open a new issue.

If the previous crash is not happening anymore we'll close this one and merge the proposed patch.

Okay @atoppi. I will open a new issue with the same gist. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants