Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Commandline option "--version" no longer exists #3383

Closed
fancycode opened this issue May 22, 2024 · 1 comment · Fixed by #3384
Closed

[1.x] Commandline option "--version" no longer exists #3383

fancycode opened this issue May 22, 2024 · 1 comment · Fixed by #3384
Labels
multistream Related to Janus 1.x

Comments

@fancycode
Copy link
Contributor

What version of Janus is this happening on?

Janus version: 1203 (1.2.3)
Janus commit: bc044995a94c623b747bb35ecb9f059190903803

Have you tested a more recent version of Janus too?
no

Was this working before?
This is working with the 0.x branch.

Additional context
Looks like this got removed by the migration away from gengetopt which added a handler for --version automatically.

We used this on our build systems as a simple check to see if all dependencies are available, so it would be great if this could be re-added. I'll check if I find some time the next days to prepare a PR myself.

@fancycode fancycode added the multistream Related to Janus 1.x label May 22, 2024
@lminiero
Copy link
Member

Looks like this got removed by the migration away from gengetopt

Yeah, this is very likely: in 1.x we create the options programmatically with GLib (GoptionEntry), which does generate a helper automatically (-h) but it doesn't indeed expose a version too as we did before. This should be added to options.c/.h. I'm out of office the next few days but I'll look into it when I'm back.

fancycode added a commit to strukturag/nextcloud-spreed-signaling that referenced this issue May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multistream Related to Janus 1.x
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants