nosip: resource leak if no answer received #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll try to review later today, thanks for your contribution! |
lminiero
reviewed
Sep 17, 2018
plugins/janus_nosip.c
Outdated
| @@ -583,6 +583,7 @@ char *janus_nosip_sdp_manipulate(janus_nosip_session *session, janus_sdp *sdp, g | |||
| /* Media */ | |||
| static int janus_nosip_allocate_local_ports(janus_nosip_session *session, gboolean update); | |||
| static void *janus_nosip_relay_thread(void *data); | |||
| static void janus_nosip_relay_thread_close_internal(janus_nosip_session *session); | |||
There was a problem hiding this comment.
I don't think the name of the method is correct, considering it is not related to the the relay thread, but is more of a cleanup of the media session: maybe something like janus_nosip_media_cleanup?
|
Looks good, merging then! Thanks again for your contribution: I think I'll try and integrate it in the SIP and SIPre plugins as well, considering they work pretty much the same way on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.