SIP plugin: Fixed update request for SRTP sessions #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This looks good to me 👍 |
|
Thank you. I will update this pull request. |
|
Ack, then I'll wait for that before merging 👍 Thanks again! |
|
@ihusejnovic I decided to merge this as it is. We can worry about NoSIP later. Thanks! |
|
@lminiero ok, I have started working on NoSIP plugin but then I realized that SRTP is not working fine for the "process" request at all. I'm also trying to fix that. Hopefully, a new pull request will arrive soon. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request is a fix for update request when SIP session is using SDES-SRTP, as I promised in my previous pull request :)
When you confirm that this is fine I will apply it to NoSIP plugin too.