Allow simulcast ports to be picked randomly in Streaming mountpoints #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, when you pass
0as a port to create a Streaming plugin mountpoint, this means a random port will be picked in the configured RTP range (the plugin's rane, not the core's). This is currently not true for the simulcast ports, though, that isvideoport2andvideoport3, which are considered to be disabled instead when you pass0. This patch changes that, and uses random ports for them whenvideosimulcast=trueand they're not provided or set to 0.This means you can't create a simulcast mountpoints with just two substreams anymore, but I don't think it's that big of a deal (not sure anyone was doing that anyway). I don't think this is controversial, so I plan to merge soon.