Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor videoroom hangup media internal. #2236

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

atoppi
Copy link
Member

@atoppi atoppi commented Jun 18, 2020

This PR addresses a crash that occurred when a videoroom subscriber session gets quickly destroyed while being established.

When this race condition happens an invalid (freed) subscriber session gets appended to the subscribers list tied to a specific publisher. Once that publisher leaves, Janus traverses the list and references again that freed session, making the process halt.

This patch basically introduces a refactoring of the hangup media methods that will avoid appending an invalid session to the publisher list.

Notice that the signature of janus_videoroom_hangup_media_internal has been changed and the method now accepts a gpointer (aka void*) in place of a janus_plugin_session*.

@lminiero
Copy link
Member

Merged, as this was tested extensively already.

@lminiero lminiero merged commit 9dff2d8 into meetecho:master Jun 18, 2020
@atoppi atoppi deleted the refactor-videoroom-hangup-media branch June 19, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants