Add more checks on validity of NUA before using it in SIP plugin #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this patch fixed the issue, so I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, there are some race conditions that can happen if the
s_nuaNUA object is destroyed after the stack loop ends, and requests to use it arrive after that. This is a first attempt to fix that, by adding more checks on the validity of the object before using it, taking advantage of the stack mutex for the purpose. I'm not able to replicate the issue myself (master works fine for me even when stress testing) so I can't check if this works: I'll wait for feedback before deciding whether this fix is enough, or if more needs to be done.