Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor memory leak in participant inbuf of audiobridge plugin #2298

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Fix minor memory leak in participant inbuf of audiobridge plugin #2298

merged 1 commit into from
Jul 27, 2020

Conversation

JeckLabs
Copy link
Contributor

According to glib documentation g_list_remove_link will not free element itself, which cause a minor memory leak in the audio bridge plugin. Probably it would be better to replace it with g_list_delete_link.

@lminiero
Copy link
Member

Have you verified if this is indeed leaking memory? It does make sense looking at the docs, but my libasan setup doesn't seem to be catching those when I close Janus and it cleans up.

@atoppi
Copy link
Member

atoppi commented Jul 27, 2020

glist links seems to be handled with memory slices, so maybe that could explain why libasan is not catching those leaks

@lminiero
Copy link
Member

Ah that would make sense. I'll make a couple of quick tests, then, and merge if I don't spot anything weird 👍

@JeckLabs
Copy link
Contributor Author

@lminiero yes, this is how I found it in the first place. I'm using Valgrind and it shows a leak in glib slice allocator. I may try to reproduce if it helps.

@lminiero
Copy link
Member

No need! Sounds good to me, thanks for spotting this: merging 👍

@lminiero lminiero merged commit 5c74a5c into meetecho:master Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants