Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kick #2332

Merged
merged 3 commits into from
Aug 31, 2020
Merged

Kick #2332

merged 3 commits into from
Aug 31, 2020

Conversation

backface
Copy link
Contributor

kicking a participant neither worked with setting "textroom":"kick" (missing request) nor "request":"kick" (unknown request "kick").
Did I get the docs wrong or is there something mixed up?
however this PR seems to work!

@januscla
Copy link

Thanks for your contribution, @backface! Please make sure you sign our CLA, as it's a required step before we can merge this.

@lminiero
Copy link
Member

@backface good catch! We probably added the "kick" request code, but forgot to list it in the synchronous methods the plugin supports. Notice you should add the same fix to janus_textroom_handle_admin_message as well, or otherwise "kick" won't be available via Admin API. I see you signed the CLA already, so as soon as that's added I'll merge 👍

@lminiero
Copy link
Member

@backface ping 🙂

@backface
Copy link
Contributor Author

added - but not tested ;)

@lminiero
Copy link
Member

Thanks, merging then!

@lminiero lminiero merged commit a453a95 into meetecho:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants