Prevent unnecessary "Unsupported codec 'none' error" #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case a party does not send audio, `audio_codec` renders `none`, which causes an unnecessary error in `janus_sdp_get_codec_rtpmap`. Because `do_audio` is already `false` at this time, it is checked and the call to `janus_sdp_get_codec_rtpmap` is prevented. Similar for video
|
Thanks, merging 👍 |
|
Thanks, Lorenzo. You are welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case a party does not send audio,
audio_codecrendersnone, which causes an unnecessary error injanus_sdp_get_codec_rtpmap. Becausedo_audiois alreadyfalseat this time, it is checked and the call tojanus_sdp_get_codec_rtpmapis prevented. Similar for video