Wait for graceful MQTT disconnect #2374
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On destroy MQTT transport publishes a offline status message and then calls
MQTTAsync_disconnect
which gracefully disconnects from the broker by sendingdisconnect
message. However this call is asynchronous and is not being awaited and the socket closes faster than the message is being sent. From the point of view of the broker it looks like ungraceful disconnection so it publishes another one offline status message as LWT. As a result subscribers get duplicated offline status messages.This PR fixes this problem by synchronizing
MQTTAsync_disconnect
call usingjanus_condition_wait_until
.