SIP plugin: SIP MESSAGE out of dialog #2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lminiero
reviewed
Apr 1, 2021
lminiero
reviewed
Apr 6, 2021
|
@lminiero I fixed all the things you suggested in the comments. Let me know if there is anything else that needs to be done. Thank you. |
|
Thanks, looks good to me now! Merging 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
In this pull request, I added the option to send a SIP MESSAGE "out of dialog". The message will be sent out of dialog if you pass the new parameter called "uri" with the SIP URI of the peer. If the "uri" parameter is not set, the message will be sent in the active dialog as it is in the current implementation. In order to send a message out of dialog, the user must be registered.
I tested it with the Kamailio and it works fine.