Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for datachannel label/protocol to Lua and Duktape plugins #2641

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

lminiero
Copy link
Member

I realized that, despite labels and subprotocols support had been added to Janus for some time already (in #1551 and #2157 respectively), we still hadn't updated the Lua and Duktape plugins accordingly. This is what this patch does.

In theory, this change is backwards compatible, meaning that if you're using datachannels and don't change anything in your lua and js script, they should just work, but you may want to double check that. Label and subprotocol are now two additional (and again, in theory optional) parameters you can add both to your incomingTextData/incomingBinaryData callbacks, and the related relayTextData/relayBinaryData methods. I updated both echotest.lua and echotest.js, so it should be trivial to see how you can change your scripts.

Feedback welcome, as I plan to merge soon.

@lminiero
Copy link
Member Author

Merging.

@lminiero lminiero merged commit 414291e into master Apr 30, 2021
@lminiero lminiero deleted the lua-duktape-dclabel branch April 30, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant